Remove the check for frontend image before cache bust #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
Discussed this with the team and we decided to achieve the same results with other approaches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the check in the cache bust code that ensures cache bust only runs if the image tag has changed. This condition was added to try to limit the amount of times we cache bust. However, there is a corner case where an image may be rebuilt with the same tag, the app redeployed as part of a larger redeploy in app-interface, the app lands on a new node so image pull occurs, the image has different assets but the same tag so it isn't re-busted. This has happened single digit times in history, but it can result in outages when it does.