Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove '/preview' and '/beta' #191

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

Victoremepunto
Copy link
Collaborator

No description provided.

@Victoremepunto Victoremepunto marked this pull request as ready for review September 25, 2024 12:18
Copy link
Collaborator

@psav psav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions and a change or two :)

Makefile Outdated Show resolved Hide resolved
controllers/reconcile.go Outdated Show resolved Hide resolved
controllers/reconcile.go Outdated Show resolved Hide resolved
controllers/reconcile.go Outdated Show resolved Hide resolved
tests/e2e/basic-frontend/02-assert.yaml Show resolved Hide resolved
@Victoremepunto Victoremepunto requested a review from psav September 25, 2024 13:34
@Victoremepunto Victoremepunto changed the title feat: remove '/preview' feat: remove '/preview' and '/beta' Sep 25, 2024
Copy link
Collaborator

@adamrdrew adamrdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never loved a PR more than this one

@adamrdrew adamrdrew merged commit 4a3dd44 into RedHatInsights:main Sep 26, 2024
11 checks passed
@Victoremepunto Victoremepunto deleted the remove-preview branch September 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants