RHCLOUD-33912: update crd spec to match chrome-service #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not mean to convert this to a PR from draft yet. Looking into the build pipeline failure (running |
psav
approved these changes
Oct 14, 2024
Hyperkid123
approved these changes
Oct 14, 2024
| ModuleConfig *ModuleConfig `json:"moduleConfig,omitempty" yaml:"moduleConfig,omitempty"` | ||
| FullProfile *bool `json:"fullProfile,omitempty" yaml:"fullProfile,omitempty"` | ||
| DefaultDocumentTitle string `json:"defaultDocumentTitle,omitempty" yaml:"defaultDocumentTitle,omitempty"` | ||
| IsFedramp *bool `json:"isFedramp,omitempty" yaml:"isFedramp,omitempty"` |
There was a problem hiding this comment.
A note for the fedramp. We should be thinking about sunsetting this attribute as it will be clear form the environment which modules are deployed and by extension eligible for the env.
| } | ||
|
|
||
| type Module struct { | ||
| ID string `json:"id" yaml:"id"` | ||
| Module string `json:"module" yaml:"module"` | ||
| Routes []Route `json:"routes" yaml:"routes"` | ||
| Dependencies []string `json:"dependencies,omitempty" yaml:"dependencies,omitempty"` | ||
| OptionalDependencies []string `json:"optionalDependencies,omitempty" yaml:"optionalDependencies,omitempty"` | ||
| Dependencies []string `json:"dependencies,omitempty" yaml:"dependencies,omitempty"` // not in the current chrome-service spec |
There was a problem hiding this comment.
These are not used. We should investigate and if no modules are suing these, we should remove them.
| Dynamic bool `json:"dynamic,omitempty" yaml:"dynamic,omitempty"` | ||
| Exact bool `json:"exact,omitempty" yaml:"exact,omitempty"` | ||
| Props *apiextensions.JSON `json:"props,omitempty" yaml:"props,omitempty"` | ||
| FullProfile bool `json:"fullProfile,omitempty" yaml:"fullProfile,omitempty"` |
There was a problem hiding this comment.
We should no longer use the full profile. Attribute. A candidate for an Action required email. After that we can remove it.
| Exact bool `json:"exact,omitempty" yaml:"exact,omitempty"` | ||
| Props *apiextensions.JSON `json:"props,omitempty" yaml:"props,omitempty"` | ||
| FullProfile bool `json:"fullProfile,omitempty" yaml:"fullProfile,omitempty"` | ||
| IsFedramp bool `json:"isFedramp,omitempty" yaml:"isFedramp,omitempty"` |
api/v1alpha1/frontend_types.go
Outdated
| type Permission struct { | ||
| Method string `json:"method" yaml:"method"` | ||
| Apps []string `json:"apps,omitempty" yaml:"apps,omitempty"` | ||
| Args []string `json:"args,omitempty" yaml:"args,omitempty"` // TODO validate array item type (string?) |
There was a problem hiding this comment.
This can be array with mixed types. [string, number, etc]. Can we use the apiextensions.JSON here? In my head [] is a valid JSON and we might be able to get away with it.
There was a problem hiding this comment.
@Hyperkid123 done! Verified locally by updating the kuttl basic frontend test with:
module:
config:
ssoUrl: 'https://'
manifestLocation: /apps/chrome/js/fed-mods.json
modules:
- id: "landing"
module: "./RootApp"
routes:
- pathname: /
exact: true
permissions:
- method: withEmail
args:
- "@redhat.com"
- 2Now passes with the JSON type:
=== CONT kuttl/harness/basic-frontend
logger.go:42: 10:40:24 | basic-frontend | Creating namespace: kuttl-test-evident-leech
logger.go:42: 10:40:24 | basic-frontend/0-create-namespace | starting test step 0-create-namespace
logger.go:42: 10:40:24 | basic-frontend/0-create-namespace | Namespace:/test-basic-app created
logger.go:42: 10:40:24 | basic-frontend/0-create-namespace | test step completed 0-create-namespace
logger.go:42: 10:40:24 | basic-frontend/1-create-resources | starting test step 1-create-resources
logger.go:42: 10:40:24 | basic-frontend/1-create-resources | FrontendEnvironment:/test-basic-app-environment created
logger.go:42: 10:40:24 | basic-frontend/1-create-resources | Frontend:test-basic-app/chrome created
logger.go:42: 10:40:24 | basic-frontend/1-create-resources | test step completed 1-create-resources
logger.go:42: 10:40:24 | basic-frontend/2- | starting test step 2-…e-crd-spec-to-match-chrome-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the FEO frontend modules with the current structure in chrome service backend. This sync is to allow for additional updates to the FEO in the future.