Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new kuttl test for fully fledged frontend config #197

Closed

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented Oct 14, 2024

Depends on #196 and the previous PRs @Hyperkid123 and I have already merged in.

This new test should flush out all the additional optional fields on a frontend resource. I want to keep both tests (basic-frontend) and this ensures we do not accidentally enforce new required fields if unnecessary.

@florkbr florkbr requested a review from Hyperkid123 October 14, 2024 23:59
@florkbr florkbr force-pushed the add-frontend-resource-full-test branch from 54beab5 to 22af806 Compare October 15, 2024 00:32
@florkbr florkbr force-pushed the add-frontend-resource-full-test branch from 22af806 to a7987c9 Compare October 15, 2024 00:44
@florkbr
Copy link
Contributor Author

florkbr commented Oct 15, 2024

FWIW running this locally will pass no matter what until 196 is merged (we seem to ignore unrecognized fields). Once there is an entry for widgets in the struct, you can tweak this test and see the kuttl tests fail.

@Hyperkid123
Copy link
Contributor

/retest

@adamrdrew
Copy link
Collaborator

09:03:37 [2024-10-17T13:03:37.963Z]     logger.go:42: 13:03:37 | full-frontend/1-create-resources | FrontendEnvironment:/test-full-app-environment created
09:03:37 [2024-10-17T13:03:37.963Z]     case.go:399: failed in step 1-create-resources
09:03:37 [2024-10-17T13:03:37.964Z]     case.go:401: Frontend.cloud.redhat.com "chrome" is invalid: [spec.widgetRegistry[0].defaults: Required value, spec.widgetRegistry[1].defaults: Required value]

@adamrdrew adamrdrew closed this Oct 17, 2024
@adamrdrew
Copy link
Collaborator

09:03:37 [2024-10-17T13:03:37.963Z]     logger.go:42: 13:03:37 | full-frontend/1-create-resources | FrontendEnvironment:/test-full-app-environment created
09:03:37 [2024-10-17T13:03:37.963Z]     case.go:399: failed in step 1-create-resources
09:03:37 [2024-10-17T13:03:37.964Z]     case.go:401: Frontend.cloud.redhat.com "chrome" is invalid: [spec.widgetRegistry[0].defaults: Required value, spec.widgetRegistry[1].defaults: Required value]

Should be an easy fix and then we can merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants