-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(routing): Updates Advisor Routes to use global schema + Remove unused packages #1285
base: master
Are you sure you want to change the base?
Conversation
9593e3d
to
1ac404d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
- Coverage 22.23% 21.61% -0.62%
==========================================
Files 96 95 -1
Lines 2559 2549 -10
Branches 811 809 -2
==========================================
- Hits 569 551 -18
- Misses 1990 1998 +8 ☔ View full report in Codecov by Sentry. |
/retest |
Nice refactor! ✨ There seem to be some minor issues, for example, the "Pathways" tab and the "Immutable ..." tab on the details both lead to broken pages. It might be that we need to updated the paths of the links/navigate there to fix these issues. Another issue is that the "Zero State" flash up, even if the account has connected systems. Other than that everything appears to work as before. |
ad5ffd8
to
d3908a2
Compare
@bastilian Thanks for taking a look! I adding in a loading const to avoid that flash, and it seems I had actually removed some routes on accident. I changed the way we mapped through routes so that it could handle arrays, and also added routes that render the same component into the same object to tidy things up. In the original we have 16 routes, this refactor has 16 as well. |
/retest |
This is mainly a routing refactor so that advisor uses the same schema as other apps. Along with some unused package clean ups.