fix(RHINENG-11976): fix loading states across app

[xmicha82]

Description

Fix loading states across app to better reflect loading components

Associated Jira ticket: RHINENG-11976

How to test the PR

Affected pages:
/recommendations - Pathways tab
/recommendation/:id - loading spinner while the tables in the tabs are loading
/topics - table
/topics/:id - rules table
/systems/:id - header, table

Checklist:

• The commit message has the Jira ticket linked
• PR has a short description
• Screenshots before and after the change are added
• Tests for the changes have been added
• README.md is updated if necessary
• Needs additional dependent work

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 22.19%. Comparing base (4cd0f99) to head (8e4e330).

Files with missing lines	Patch %	Lines
...entationalComponents/Inventory/InventoryDetails.js	0.00%	2 Missing ⚠️
.../PresentationalComponents/RulesTable/RulesTable.js	0.00%	2 Missing ⚠️
...resentationalComponents/TopicsTable/TopicsTable.js	0.00%	2 Missing ⚠️
...ntationalComponents/PathwaysTable/PathwaysTable.js	0.00%	1 Missing ⚠️
src/SmartComponents/Recs/List.js	0.00%	1 Missing ⚠️
src/SmartComponents/SystemAdvisor/SystemAdvisor.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
- Coverage   22.22%   22.19%   -0.04%     
==========================================
  Files          96       96              
  Lines        2560     2564       +4     
  Branches      811      811              
==========================================
  Hits          569      569              
- Misses       1991     1995       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[leSamo]

This is a step in the right direction, I added some suggestions; I'd say the ideal state is to remove the Loading component since it's super ugly and replace all occurrences of SkeletonTable from FEC to PF component groups. This can be done in a single or multiple PRs.

[Fewwy]

/retest

[xmicha82]

/retest

[leSamo]

Nice improvements, I just added some minor comments to fix.

[gkarat]

I am surprised these massive changes to package-lock.json are really necessary. As I can see from package.json, we have only added the @patternfly/react-component-groups library. Could you please double-check if dependencies are updated correctly?

[leSamo]

I agree with Georgii, package.json and package-lock.json do not correspond to one another -- the easiest fix would be to revert changes to both files and install @patternfly/react-component-groups again.

[leSamo]

Other than that the PR is good to be merged IMO.