-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add conditional filters to cypress tests #1315
base: master
Are you sure you want to change the base?
add conditional filters to cypress tests #1315
Conversation
@opacut your errors are for linting. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 22.22% 22.22%
=======================================
Files 96 96
Lines 2560 2560
Branches 811 811
=======================================
Hits 569 569
Misses 1991 1991 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code climate bot is suggesting refactoring the following into a separate function. You could call an external helper function and pass in the value for contains
and have it do these actions.
cy.get(CONDITIONAL_FILTER_TOGGLE).click();
cy.get(PT_CONDITIONAL_FILTER_LIST).contains('Name').click();
Description
Associated Jira ticket: RHINENG-14743
Add Conditional filter Cypress tests
How to test the PR
run npm test:ct
Before the change
90 tests are run
After the change
At least 91 tests are run, including The Bulk selector shows the correct number of systems selected.
Dependent work link
Checklist: