Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conditional filters to cypress tests #1315

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

opacut
Copy link
Contributor

@opacut opacut commented Dec 10, 2024

Description

Associated Jira ticket: RHINENG-14743

Add Conditional filter Cypress tests

How to test the PR

run npm test:ct

Before the change

90 tests are run

After the change

At least 91 tests are run, including The Bulk selector shows the correct number of systems selected.

Dependent work link

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@opacut opacut marked this pull request as ready for review December 11, 2024 12:58
@opacut opacut requested a review from a team as a code owner December 11, 2024 12:58
@johnsonm325
Copy link
Contributor

@opacut your errors are for linting. npm run lint should give you everything you need.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.22%. Comparing base (db649f5) to head (6e1ed99).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   22.22%   22.22%           
=======================================
  Files          96       96           
  Lines        2560     2560           
  Branches      811      811           
=======================================
  Hits          569      569           
  Misses       1991     1991           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johnsonm325 johnsonm325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code climate bot is suggesting refactoring the following into a separate function. You could call an external helper function and pass in the value for contains and have it do these actions.

      cy.get(CONDITIONAL_FILTER_TOGGLE).click();
      cy.get(PT_CONDITIONAL_FILTER_LIST).contains('Name').click();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants