Skip to content

Commit

Permalink
Remove log checks, rely on process already finished
Browse files Browse the repository at this point in the history
  • Loading branch information
joselsegura committed Nov 2, 2023
1 parent 180c0d5 commit fc0c06e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 0 additions & 10 deletions features/parquet-factory/kafka_messages.feature
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,6 @@ Feature: Ability to process the Kafka messages correctly
And I set the environment variable "PARQUET_FACTORY__KAFKA_FEATURES__MAX_CONSUMED_RECORDS" to "1"
And I run Parquet Factory with a timeout of "10" seconds
Then Parquet Factory should have finish
And The logs should contain
| topic | partition | offset | message |
| incoming_features_topic | 0 | 0 | message processed |
| incoming_features_topic | 1 | 0 | message processed |
| incoming_rules_topic | 0 | 0 | message processed |
| incoming_rules_topic | 1 | 0 | message processed |
| incoming_features_topic | 0 | 1 | FINISH |
| incoming_features_topic | 1 | 1 | FINISH |
| incoming_rules_topic | 0 | 1 | FINISH |
| incoming_rules_topic | 0 | 1 | FINISH |
Then The S3 bucket is not empty

Scenario: Parquet Factory should not commit the messages from current hour if there are no prior messages
Expand Down
10 changes: 10 additions & 0 deletions parquet_factory_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ function code_coverage_report() {
EOF
}

function add_exit_trap {
local to_add=$1
if [[ -z "$exit_trap_command" ]]
then
exit_trap_command="$to_add"
else
exit_trap_command="$exit_trap_command; $to_add"
fi
}

flag=${1:-""}

if [[ "${flag}" = "coverage" ]]
Expand Down

0 comments on commit fc0c06e

Please sign in to comment.