Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new service to our BDD tests from ccx-bdd-tests #514

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

joselsegura
Copy link
Collaborator

@joselsegura joselsegura commented Oct 23, 2023

Description

Migrating the parquet-factory BDD tests from ccx-bdd-tests to this repository.

Fixes # (issue)

Type of change

  • New test feature file
  • Non-breaking change in test steps implementation

Testing steps

docker-compose --profile test-parquet-factory up -d && make parquet-factory-tests

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

Copy link
Collaborator

@Bee-lee Bee-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some merge conflicts, though

Copy link
Member

@matysek matysek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joselsegura joselsegura merged commit 3079e92 into main Nov 2, 2023
14 checks passed
@joselsegura joselsegura deleted the parquet-factory branch November 20, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants