Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-12111] Adapt run_in_docker.sh script to Github workflows #517

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Oct 24, 2023

Description

Remove the -it parameters from the docker exec command used to run the BDD tests. It's a leftover from using the command in manual tests, and it does not work in GitHub workflows as the pseudo TTY is not allocated.

Fixes CCXDEV-12111

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

CI of our services should be able to run the script

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epapbak epapbak merged commit 13cd480 into RedHatInsights:main Oct 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants