Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-11831] Update log message expected when report to notify is detected #518

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Oct 25, 2023

Description

As part of CCXDEV-11831, I updated the log message that indicates when a report with enough impact to be notified is detected. This updates the tests where said log message is checked.

Fix for RedHatInsights/ccx-notification-service#650.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing steps

run_in_docker.sh notification-service-tests <path_to_local_notification_service_repo_with_latest_changes>

7 features passed, 0 failed, 0 skipped
56 scenarios passed, 0 failed, 3 skipped
674 steps passed, 0 failed, 6 skipped, 0 undefined
Took 0m57.116s
+ bddExecutionExitCode=0

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epapbak epapbak merged commit 619e2ea into RedHatInsights:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants