Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing boto3 requirement to sha-extractor #521

Merged

Conversation

Bee-lee
Copy link
Collaborator

@Bee-lee Bee-lee commented Nov 1, 2023

Description

boto3 was recently added to the sha-extractor tests; adding to requirements.txt

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration update

Testing steps

Please describe how the change was tested locally. If, for some reason, the testing was not done or not done fully, please describe what are the testing steps.

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bee-lee Bee-lee merged commit 380b142 into RedHatInsights:main Nov 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants