Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail other tests than SHA extractor ones #522

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Don't fail other tests than SHA extractor ones #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions features/steps/insights_sha_extractor_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,19 @@

"""Implementation of logic behind usage of S3 and Kafka in SHA extractor tests."""

import boto3
import json
import logging
import os

import json
from behave import when
from botocore.exceptions import ClientError
from src import kafka_util

try:
import boto3
from botocore.exceptions import ClientError
except ImportError as e:
print("Warning: unable to import module:", e)


def create_presigned_url(s3_client, bucket_name, object_name, expiration=3600):
"""Generate a presigned URL to share an S3 object."""
Expand Down