-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose postgres DB on port 25432 instead of 5432 #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, don't merge.
I'm not sure about the port is not used by the automation. IIRC some of the scripts define a bunch of environment variables and maybe there the potr is being defined
I just reviewed and I can see that the port is used in:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't realize that for docker-compose containers de port will remain untouched, it's just a change if you try to connect from the host.
Sorry for delaying you
@joselsegura I think there's a misunderstanding. When using the |
tested by running the tests within docker and no local postgres running |
Description
The exposed port is not used by any of the automation of this repository. Instead, it is just used for debugging when needed. Let's use 25432 so it does not conflict with any locally running PSQL server
Type of change
Testing steps
Tested locally
Checklist