Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare run_in_docker script to use podman or docker #602

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

epapbak
Copy link
Collaborator

@epapbak epapbak commented Jul 5, 2024

Description

Small improvement to try to run the script using podman or docker if they are installed.

As long as docker and podman's arguments remain compatible, this should do the trick.

Type of change

Improvement

Testing steps

I just used run_in_docker with podman

Checklist

  • Pylint passes for Python sources
  • sources has been pre-processed by Black
  • updated documentation wherever necessary
  • new tests can be executed both locally and within docker container
  • new tests have been included in scenario list (make update-scenarios)

@epapbak epapbak force-pushed the run_with_docker_or_podman branch 2 times, most recently from a5ed020 to d4d2979 Compare July 5, 2024 15:00
Copy link
Collaborator

@joselsegura joselsegura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the same thing for choosing a "composer"? For example, I use docker compose instead of docker-compose or podman-compose, so it would be great to have.

If you see it more complex, just ignore this comment

@epapbak epapbak force-pushed the run_with_docker_or_podman branch from 566198c to f77aa82 Compare July 8, 2024 09:18
@epapbak epapbak marked this pull request as draft July 8, 2024 09:25
@epapbak epapbak force-pushed the run_with_docker_or_podman branch from f77aa82 to cb74191 Compare August 7, 2024 09:07
@epapbak epapbak force-pushed the run_with_docker_or_podman branch from cb74191 to 7bbcc45 Compare August 9, 2024 07:45
@epapbak epapbak force-pushed the run_with_docker_or_podman branch from 6f4c487 to 152c429 Compare August 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants