Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Undocument --conf and --logging-file #318

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pkoprda
Copy link
Contributor

@pkoprda pkoprda commented Dec 16, 2024

  • Card ID: CCT-732

The CLI includes many flags that could be reimplemented, but conf and logging-file are harder to support and offer little value to customers. Instead of removing them from the CLI, we'll remove them from the man page and document the change in the RHEL release notes, as Core is shipped to RHEL 6+ and cannot immediately remove these flags.

* Card ID: CCT-732

The CLI includes many flags that could be reimplemented, but `conf` and
`logging-file` are harder to support and offer little value to
customers. Instead of removing them from the CLI, we'll remove them from
the man page and document the change in the RHEL release notes, as Core
is shipped to RHEL 6+ and cannot immediately remove these flags.
Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky
Copy link
Contributor

m-horky commented Dec 17, 2024

FAILED integration-tests/test_checkin.py::test_client_checkin_unregistered
FAILED integration-tests/test_client_options.py::test_check_show_results
FAILED integration-tests/test_connection.py::test_http_timeout
FAILED integration-tests/test_file_workflow.py::test_file_workflow_with_an_archive_with_only_one_canonical_fact

The downstream fails on unrelated issues, good to merge.

@m-horky m-horky merged commit 82e1554 into RedHatInsights:master Dec 17, 2024
20 of 21 checks passed
@pkoprda pkoprda deleted the undocument-conf branch December 17, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants