feat(update to pf5): update dependencies to work with PF5 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karelhala
force-pushed
the
update-to-pf5
branch
2 times, most recently
from
071e148 to
b7ddd20
Compare
fhlavac
approved these changes
Feb 12, 2024
|
Overall looks good, just some tests seem to be failing |
karelhala
force-pushed
the
update-to-pf5
branch
2 times, most recently
from
7587ec9 to
1420520
Compare
karelhala
force-pushed
the
update-to-pf5
branch
from
1420520 to
5e75f47
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 88.79% 89.36% +0.56%
==========================================
Files 60 60
Lines 937 959 +22
Branches 166 181 +15
==========================================
+ Hits 832 857 +25
+ Misses 105 102 -3 ☔ View full report in Codecov by Sentry. |
|
@josejulio looks like the release failed. I guess I should do manual one, right? |
That would be ok i guess. Very odd that it failed, probably some missing lint on a test file or similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since PF4 will soon not be supported we have to switch to PF5. This allows us to import dynamic components and layouts that way our chunks are not too big.
JIRA
https://issues.redhat.com/browse/RHCLOUD-30342