Skip to content

Commit

Permalink
Deprecate insights.core.scannable & engine_log parser (#3541)
Browse files Browse the repository at this point in the history
The following will be deprecated after insights-core-3.2.25:
* insights.core.scannable: Better use the `core.Parser` with filter.
* insights.parsers.engine_log: Use insights.parsers.ovirt_engine_log instead.

Signed-off-by: Sachin Patil <[email protected]>
  • Loading branch information
Sachin authored Oct 13, 2022
1 parent b495112 commit d11ac70
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions insights/core/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,9 @@ def has_fcoe_edd(line):
strings or False).
"""
def __init__(self, *args, **kwargs):
deprecated(Scannable, "Please use the :class:`insights.core.Parser` instead", "3.2.25")
super(Scannable, self).__init__(*args, **kwargs)

@classmethod
def _scan(cls, result_key, scanner):
Expand Down
2 changes: 1 addition & 1 deletion insights/parsers/engine_log.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ class EngineLog(LogFileOutput):
Provide access to ovirt engine logs using the LogFileOutput parser class.
"""
def __init__(self, *args, **kwargs):
deprecated(EngineLog, "Import EngineLog from insights.parsers.ovirt_engine_log instead")
deprecated(EngineLog, "Import EngineLog from insights.parsers.ovirt_engine_log instead", "3.2.25")
super(EngineLog, self).__init__(*args, **kwargs)

0 comments on commit d11ac70

Please sign in to comment.