validate the max_match in test

Signed-off-by: Xiangce Liu <[email protected]>

insights/core/filters.py

@@ -107,6 +107,9 @@ def inner(comp, patterns):
 
         FILTERS[comp].update(max_matchs(FILTERS[comp], patterns))
 
+    if max_match is None or (type(max_match) is not int or max_match <= 0):
+        raise Exception("Invalid argument 'max_match' to the add_filter: {0}".format(max_match))
+
     if not plugins.is_datasource(component):
         deps = get_dependency_datasources(component)
         if deps:

insights/tests/core/test_filters.py

@@ -200,6 +200,24 @@ def test_add_filter_exception_None():
         filters.add_filter(Specs.ps_aux, None)
 
 
+def test_add_filter_exception_with_invalid_max_match():
+    with pytest.raises(Exception) as ex:
+        filters.add_filter(Specs.ps_aux, 'abctest', 'str')
+    assert "Invalid argument 'max_match' to the add_filter: str" in str(ex)
+
+    with pytest.raises(Exception) as ex:
+        filters.add_filter(Specs.ps_aux, 'abctest', 0)
+    assert "Invalid argument 'max_match' to the add_filter: 0" in str(ex)
+
+    with pytest.raises(Exception) as ex:
+        filters.add_filter(Specs.ps_aux, 'abctest', -1)
+    assert "Invalid argument 'max_match' to the add_filter: -1" in str(ex)
+
+    with pytest.raises(Exception) as ex:
+        filters.add_filter(Specs.ps_aux, 'abctest', None)
+    assert "Invalid argument 'max_match' to the add_filter: None" in str(ex)
+
+
 def test_get_filters():
     _filter = 'A filter'
     filters.add_filter(MySpecs.has_filters, _filter)