fix(client): Serialize properly escape characters (#4335)

* Card ID: CCT-1065 Backslashes in regex patterns were not properly escaped, causing inconsistencies between Fedora 40 and CentOS Stream 9 environments. This commit ensures that all escape characters are properly serialized. Signed-off-by: pkoprda <[email protected]>
RedHatInsights · Jan 15, 2025 · f8451aa · f8451aa
1 parent c530404
commit f8451aa
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/insights/client/apps/ansible/playbook_verifier/serializer.py b/insights/client/apps/ansible/playbook_verifier/serializer.py
@@ -49,7 +49,20 @@ def _str(cls, value):
         # single'quote  "single'quote"
         # double"quote  'double"quote'
         # both"'quotes  'both"\'quotes'
+        # \backslash    '\\backslash'
+        # new\nline     'new\\nline'
+        # tab\tchar     'tab\\tchar'
 
+        special_chars = {
+            "\\": "\\\\",
+            "\n": "\\n",
+            "\t": "\\t",
+        }
+        escaped_string = ""
+        for char in value:
+            escaped_string += special_chars.get(char, char)
+
+        value = escaped_string
         quote = "'"
         if "'" in value:
             if '"' not in value:

diff --git a/insights/tests/client/apps/test_playbook_verifier.py b/insights/tests/client/apps/test_playbook_verifier.py
@@ -366,7 +366,10 @@ def test_numbers(self, source, expected):
             ("no quote", "'no quote'"),
             ("single'quote", '''"single'quote"'''),
             ("double\"quote", """'double"quote'"""),
-            ("both\"'quotes", r"""'both"\'quotes'""")
+            ("both\"'quotes", r"""'both"\'quotes'"""),
+            ("\\backslash", "'\\\\backslash'"),
+            ("new\nline", "'new\\nline'"),
+            ("tab\tchar", "'tab\\tchar'"),
         ]
     )
     def test_strings(self, source, expected):