Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbitmq docker bundle #2045

Closed

Conversation

zerodayz
Copy link
Contributor

@zerodayz zerodayz commented Jul 8, 2019

Adding RabbitMQ docker bundle check for OSP containers

zerodayz and others added 2 commits July 8, 2019 14:19
Update insights-core in zerodayz repository
Adding RabbitMQ spec file for OSP containers.

Signed-off-by: Robin Cernin <[email protected]>
@zerodayz zerodayz force-pushed the rabbitmq-docker-bundle branch from 1434dc0 to 05eb827 Compare July 8, 2019 04:24
@@ -98,7 +98,11 @@ class SosSpecs(Specs):
simple_file("sos_commands/foreman/foreman-debug/qpid_stat_subscriptions"),
simple_file("sos_commands/foreman/foreman-debug/qpid-stat-u")
])
rabbitmq_report = simple_file("sos_commands/rabbitmq/rabbitmqctl_report")
rabbitmq_report = first_of([
Copy link
Contributor

@xiangce xiangce Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the glob_file means a couple of files which matches the wildcard string will get this parser being fired, this update will change the structure of the parser result, from a single Parser object to a list of Parser objects, which will break all the existing rules depend on this Parser.

If there any difference (e.g. the usage in rules) between this Parser against containers or against normal-hosts?

To avoid breaking the existing rules, seems we'd better add a new spec&parser for the new one against containers.

Or, is it possible to add a new command to the sos package to collect a single rabbitmqctl_report for one container?

Just like: #1976

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xiangce The * is there because the file changes per server, it can be any number. Do you have anything to catch that in insights?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerodayz - per the discussion, I have opened an issue #2049 for this PR. And I will submit another PR for the parser and close this one. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants