Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate insights.core.scannable & engine_log parser #3541

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Deprecate insights.core.scannable & engine_log parser #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions insights/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,9 @@ def has_fcoe_edd(line):
strings or False).

"""
def __init__(self, *args, **kwargs):
deprecated(Scannable, "Please use the :class:`insights.core.Parser` instead", "3.2.25")
super(Scannable, self).__init__(*args, **kwargs)

@classmethod
def _scan(cls, result_key, scanner):
Expand Down
2 changes: 1 addition & 1 deletion insights/parsers/engine_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,5 @@ class EngineLog(LogFileOutput):
Provide access to ovirt engine logs using the LogFileOutput parser class.
"""
def __init__(self, *args, **kwargs):
deprecated(EngineLog, "Import EngineLog from insights.parsers.ovirt_engine_log instead")
deprecated(EngineLog, "Import EngineLog from insights.parsers.ovirt_engine_log instead", "3.2.25")
super(EngineLog, self).__init__(*args, **kwargs)