Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Improper Method Call: __str__ #3975

Merged

Conversation

fazledyn-or
Copy link
Contributor

The __str__ method of class GetconfPageSize
contains an unexpected parameter called context
that has no use in the method at all. Keeping the
parameter would result in an error. As a fix, I've
removed the parameter.

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Details

While triaging your project, our bug fixing tool generated the following message(s)-

In file: getconf_pagesize.py, class: GetconfPageSize, there is a special method __str__ that contains an unexpected number of parameters. Each call to this method will result in a TypeError. iCR suggested that special methods should have an expected number of parameters. More infomation can be found in the Python documentation on the various special method.

As a fix, I've removed the unnecessary parameter context from the __str__ method.

CLA Requirements

This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.

All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support

This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.

The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

The `__str__` method of class `GetconfPageSize`
contains an unexpected parameter called `context`
that has no use in the method at all. Keeping the
parameter would result in an error. As a fix, I've
removed the parameter.

Signed-off-by: fazledyn-or <[email protected]>
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fazledyn-or - Thanks for fixing this.

@xiangce xiangce merged commit 192d370 into RedHatInsights:master Dec 13, 2023
7 checks passed
xiangce pushed a commit that referenced this pull request Dec 14, 2023
The `__str__` method of class `GetconfPageSize`
contains an unexpected parameter called `context`
that has no use in the method at all. Keeping the
parameter would result in an error. As a fix, I've
removed the parameter.

Signed-off-by: fazledyn-or <[email protected]>
(cherry picked from commit 192d370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants