fix: Remove pruning client code from rpm #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A while back datasources were added that referenced client code, this broke the rpm usage because it pruned the client code in it's build. This weirdly caused some specs to work, and some to not which caused it to go un-noticed for a bit. * This change removes the prune line that removed the client code in the build process. So the rpms will be slightly larger, but will allow specs to work properly again. Signed-off-by: Ryan Blakley <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Dec 14, 2023
* A while back datasources were added that referenced client code, this broke the rpm usage because it pruned the client code in it's build. This weirdly caused some specs to work, and some to not which caused it to go un-noticed for a bit. * This change removes the prune line that removed the client code in the build process. So the rpms will be slightly larger, but will allow specs to work properly again. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit fec486a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
A while back datasources were added that referenced client code, this broke the rpm usage because it pruned the client code in it's build. This weirdly caused some specs to work, and some to not which caused it to go un-noticed for a bit. This change removes the prune line that removed the client code in the build process. So the rpms will be slightly larger, but will allow specs to work properly again.