Fix and test IdM related parsers and combiners #4178
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
@pbrezina - Since the insights-core is a public open-source project, other than the internal projects, there might be other unknown project depends on it, we'd make sure the new changes won't break their usage.
BTW, May I know the context about why you raise this PR, e.g., a Jira card or a customer case?
| @@ -727,7 +727,8 @@ class Specs(SpecSet): | |||
| sshd_config_d = RegistryPoint(multi_output=True, filterable=True) | |||
| sshd_config_perms = RegistryPoint(no_obfuscate=['hostname', 'ip']) | |||
| sshd_test_mode = RegistryPoint(filterable=True) | |||
| sssd_config = RegistryPoint() | |||
| sssd_conf = RegistryPoint() | |||
| sssd_conf_d = RegistryPoint(multi_output=True) | |||
There was a problem hiding this comment.
To add a new spec, please file a RHINENG Jira card with "Component=Insights Spec" to get it approved first.
There was a problem hiding this comment.
Sure, I'll look into it.
I'll send the ticket to you privately, as it is not publicly accessible. |
pbrezina
force-pushed
the
idm
branch
3 times, most recently
from
0c629bd to
94a199e
Compare
|
@xiangce Please, see updated patches. |
|
Fixed docs. |
|
@pbrezina Just a reminder... the PR CI code-tests runs into the flake8 errors, eg. |
I removed the asterisk completely. Without escaping it, sphinx will complain. If I escape it, flake will complain. |
pbrezina
force-pushed
the
idm
branch
2 times, most recently
from
65a3bd4 to
0a2550d
Compare
* fix(parsr): do not auto-create magic methods in __getattr__ The previous code would just provide any attribute, including the magic methods. Especially __deepcopy__ method that breaks deepcopy(parser_object). Signed-off-by: Pavel Březina <[email protected]> * fix(identity_domain): use correct SSSD realm option SSSD does not have krb5_domain, but krb5_realm. Signed-off-by: Pavel Březina <[email protected]> * fix(identity_domain): do not add realm twice This realm could have been already added as SSSD domain. Signed-off-by: Pavel Březina <[email protected]> * fix(sssd): refactor the code, fix issues and add SSSDConfAll Existing implementation of SSSD configuration parser did not consinder SSSD's include directory and other new functionality. * Add support for sssd.conf and conf.d include folder * Add SSSDConfAll combiner that merge all configuration files together * Add support for [domain/$dom]/enabled in addition to [sssd]/domain * Refactor the code to follow naming convention of other parsers/combiners Signed-off-by: Pavel Březina <[email protected]> * fix(ipa): simplify code and logic The current IPA combiner logic was quite complex, difficult to test and prone to errors. * It is sufficient to only test the SSSD configuration in order to get the server mode, other checks are redundant. * It is sufficient if there is any SSSD domain with ipa provider to get the client mode * SSSD domain name may differ from the IPA domain name, even though this is not the default setup, it can be changed. * Release information was removed, it make testing unnecessarily more complex. * It is possible to configure SSSD as IPA client without the freeipa-client package if one does not use ipa-client-install or realm command. Checking if SSSD package is there and IPA domain is configured is sufficient. Signed-off-by: Pavel Březina <[email protected]> * fix(identity_domain): write extensive tests ...and make krb5 configuration deterministic. Signed-off-by: Pavel Březina <[email protected]> --------- Signed-off-by: Pavel Březina <[email protected]> (cherry picked from commit 66c6081)
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This pull request fix multiple issues in ipa, sssd and identity_domain. Each commit has its own description about the fix. It also adds extensive tests to verify its functionality.