fix: NoFilterException is redundant, remove it #4185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the former version, when collecting filterable 'glob_file' specs, an unexpected "Traceback" info will be printed in the debug log. In fact, it's not necessary to add the NoFilterException, in that case, the ContentException can be leveraged, we just need to log it into the debug instead of raising it again. Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
no_filter_exception
branch
from
cb835b6 to
6fedf62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the former version, when collecting filterable 'glob_file'
specs, an unexpected "Traceback" info will be printed in
the debug log.
In fact, it's not necessary to add the NoFilterException,
in that case, the ContentException can be leveraged, we
just need to log it into the debug instead of raising it again.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes: