-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: download egg as per the RHEL major version #4266
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4266 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 767 767
Lines 41762 41768 +6
Branches 8818 8818
=======================================
+ Hits 32232 32238 +6
- Misses 8462 8463 +1
+ Partials 1068 1067 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial tests on RHEL 8 and 9 passed. 👍
@m-horky - Thanks a lot for the review and test. I will ask @zhangqianqian for more QE tests. And once we are all ready I'll merge it. |
Can one of the admins verify this patch? |
- Mulitple eggs will be provided on CDN for different RHEL releases - Decide the egg name before downloading according to the current RHEL major version - The orignial "insights-core.egg" is set as default - Jira Card: RHINENG-12166 Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
c419fce
to
29c240b
Compare
- Mulitple eggs will be provided on CDN for different RHEL releases - Decide the egg name before downloading according to the current RHEL major version - The orignial "insights-core.egg" is set as default - Jira Card: RHINENG-12166 Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> (cherry picked from commit 3f36ec2)
- Mulitple eggs will be provided on CDN for different RHEL releases - Decide the egg name before downloading according to the current RHEL major version - The orignial "insights-core.egg" is set as default - Jira Card: RHINENG-12166 Signed-off-by: Xiangce Liu <xiangceliu@redhat.com> (cherry picked from commit 3f36ec2) (cherry picked from commit 8299a13)
All Pull Requests:
Check all that apply: