Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: download egg as per the RHEL major version #4266

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Nov 8, 2024

  • Mulitple eggs will be provided on CDN for different RHEL releases
  • Decide the egg name before downloading according to the current RHEL major version
  • The orignial "insights-core.egg" is set as default
  • Jira Card: RHINENG-12166

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Sorry, something went wrong.

@xiangce xiangce marked this pull request as draft November 8, 2024 13:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (08fd76a) to head (6d353ee).

Files with missing lines Patch % Lines
insights/client/__init__.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4266   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         767      767           
  Lines       41762    41768    +6     
  Branches     8818     8818           
=======================================
+ Hits        32232    32238    +6     
- Misses       8462     8463    +1     
+ Partials     1068     1067    -1     
Flag Coverage Δ
unittests 77.16% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@m-horky m-horky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial tests on RHEL 8 and 9 passed. 👍

@xiangce xiangce marked this pull request as ready for review December 4, 2024 00:47
@xiangce
Copy link
Contributor Author

xiangce commented Dec 4, 2024

@m-horky - Thanks a lot for the review and test. I will ask @zhangqianqian for more QE tests. And once we are all ready I'll merge it.

@xiangce xiangce added the WIP Includes: Approved but Not Ready for Merging/Releasing label Dec 4, 2024
@jenkins-qa-bot
Copy link
Collaborator

Can one of the admins verify this patch?

- Mulitple eggs will be provided on CDN for different RHEL releases
- Decide the egg name before downloading according to the current
  RHEL major version
- The orignial "insights-core.egg" is set as default
- Jira Card: RHINENG-12166

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
@xiangce xiangce force-pushed the fetch_eggs_per_rhel branch from c419fce to 29c240b Compare December 10, 2024 12:16
@xiangce xiangce merged commit 3f36ec2 into RedHatInsights:master Dec 16, 2024
13 checks passed
@xiangce xiangce deleted the fetch_eggs_per_rhel branch December 16, 2024 06:38
@xiangce xiangce added QE and removed WIP Includes: Approved but Not Ready for Merging/Releasing labels Dec 16, 2024
xiangce added a commit that referenced this pull request Jan 2, 2025
- Mulitple eggs will be provided on CDN for different RHEL releases
- Decide the egg name before downloading according to the current
  RHEL major version
- The orignial "insights-core.egg" is set as default
- Jira Card: RHINENG-12166

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
(cherry picked from commit 3f36ec2)
xiangce added a commit that referenced this pull request Jan 2, 2025
- Mulitple eggs will be provided on CDN for different RHEL releases
- Decide the egg name before downloading according to the current
  RHEL major version
- The orignial "insights-core.egg" is set as default
- Jira Card: RHINENG-12166

Signed-off-by: Xiangce Liu <xiangceliu@redhat.com>
(cherry picked from commit 3f36ec2)
(cherry picked from commit 8299a13)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants