fix(client): Display correct Insights URL #4297
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4297 +/- ##
==========================================
- Coverage 76.98% 76.97% -0.02%
==========================================
Files 735 735
Lines 41306 41311 +5
Branches 8772 8773 +1
==========================================
- Hits 31801 31800 -1
- Misses 8439 8444 +5
- Partials 1066 1067 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can one of the admins verify this patch? |
xiangce
added
the
client
There was a problem hiding this comment.
Matyáš gave ✅, so I am only giving a comment. I’d consider the URL parsing, but since we’re only dealing with know Red Hat URLs, in is probably fine.
I didn’t test running --register against stage. Unfortunately, I don’t know how to configure RHSM and the Client to connect to stage. If you know, please tell me.
| if "stage" in config.base_url: | ||
| console_url = "https://console.stage.redhat.com/insights/" |
There was a problem hiding this comment.
I‘d go with something more robust like
| if "stage" in config.base_url: | |
| console_url = "https://console.stage.redhat.com/insights/" | |
| hostname = urlparse(config.base_url).hostname | |
| if hostname.endswith("stage.redhat.com"): | |
| console_url = "https://console.stage.redhat.com/insights/" |
I’d even consider a function in insights.client.config and an enum with PRODUCTION, STAGE, SATELLITE options. I’ll utilize that in my CCT-963. That’d be over the scope of this simple PR though.
* Card ID: CCT-1008 With the introduction of IoP, the `insights-client` should display the correct URL for the respective environment. The client differentiates between Hosted, Stage Hosted, and IoP environments during registration. Signed-off-by: pkoprda <[email protected]>
|
🎉 Merge? @xiangce |
|
Thanks! ❤️ |
* Card ID: CCT-1008 With the introduction of IoP, the `insights-client` should display the correct URL for the respective environment. The client differentiates between Hosted, Stage Hosted, and IoP environments during registration. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit 5be3260)
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
With the introduction of IoP, the
insights-clientshould display the correct URL for the respective environment. The client differentiates between Hosted, Stage Hosted, and IoP environments during registration.