Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove planned deprecations for bumping 3.5.0 #4308

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Dec 16, 2024

  • RHINENG-14089
  • remove the relevant tests and doc entries
  • and commit update done by black pre-commit hooks
  • it will break some exiting tests in rules, hence, tests need to be updated accordingly

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@xiangce xiangce added the BREAK Rules The change breaks the test of some rules. label Dec 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.97%. Comparing base (721cb83) to head (1c5c138).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
- Coverage   77.22%   76.97%   -0.25%     
==========================================
  Files         766      735      -31     
  Lines       41822    41300     -522     
  Branches     8839     8770      -69     
==========================================
- Hits        32295    31791     -504     
+ Misses       8457     8441      -16     
+ Partials     1070     1068       -2     
Flag Coverage Δ
unittests 76.96% <100.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangce xiangce force-pushed the deprecate_3.5.0 branch 2 times, most recently from 005ada5 to 9da59da Compare December 19, 2024 06:48
@xiangce xiangce marked this pull request as ready for review December 19, 2024 06:48
- RHINENG-14089
- remove the relevant tests and doc entries
- and commit update done by black pre-commit hooks
- it will break some exiting tests in rules,
  hence, tests need to be updated accordingly

Signed-off-by: Xiangce Liu <[email protected]>
@xiangce xiangce merged commit 56c600f into RedHatInsights:master Dec 30, 2024
14 of 16 checks passed
@xiangce xiangce deleted the deprecate_3.5.0 branch December 30, 2024 05:59
xiangce added a commit that referenced this pull request Jan 2, 2025
- RHINENG-14089
- remove the relevant tests and doc entries
- and commit update done by black pre-commit hooks
- it will break some exiting tests in rules,
  hence, tests need to be updated accordingly

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 56c600f)
xiangce added a commit that referenced this pull request Jan 2, 2025
- RHINENG-14089
- remove the relevant tests and doc entries
- and commit update done by black pre-commit hooks
- it will break some exiting tests in rules,
  hence, tests need to be updated accordingly

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 56c600f)
(cherry picked from commit 79b074b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAK Rules The change breaks the test of some rules.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants