feat: add a base parser LazyLogFileOutput #4309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4309 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 765 765
Lines 41753 41770 +17
Branches 8815 8821 +6
=======================================
+ Hits 32221 32238 +17
Misses 8464 8464
Partials 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qinpingli
reviewed
Dec 17, 2024
qinpingli
reviewed
Dec 17, 2024
qinpingli
reviewed
Dec 17, 2024
xiangce
force-pushed
the
lazy_logfile
branch
from
2a380e0 to
3f792db
Compare
xiangce
changed the title
xiangce
force-pushed
the
lazy_logfile
branch
5 times, most recently
from
578c682 to
ddfab60
Compare
- Doesn't like the LogFileOutput, the LazyLogFileOutput doesn't load the content during initialization, its content can only be loaded via calling the `do_scan` method explicitly. - It's useful for the cases which need to load thousands of files belongs to one single Spec in one pass of running. - For implementation's convenience, converted the "scanners" from `list` `dict` in which the `result_key` is key and `scanner` is value. And removed the `scanner_keys`. - Update the LsPci accordingly. - see RHINENG-13810 Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
lazy_logfile
branch
from
ddfab60 to
c18899a
Compare
xiangce
changed the title
Signed-off-by: Xiangce Liu <[email protected]>
JoySnow
reviewed
Dec 18, 2024
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
lazy_logfile
branch
from
80ef82e to
7e9f0b1
Compare
JoySnow
approved these changes
Dec 19, 2024
xiangce
added a commit
that referenced
this pull request
Jan 2, 2025
- Doesn't like the LogFileOutput, this LazyLogFileOutput doesn't load the content during initialization. Its content will be loaded later whenever the parser instance being used. - It's useful for the cases where need to load thousands of files that belong to one single Spec in one pass of running. - For implementation's convenience, converted the `"scanners"` from `list` `dict` in which the `result_key` is key and `scanner` is value. And removed the `scanner_keys`. - Updated the LsPci accordingly. - RHINENG-13810 Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 1597f13)
xiangce
added a commit
that referenced
this pull request
Jan 2, 2025
- Doesn't like the LogFileOutput, this LazyLogFileOutput doesn't load the content during initialization. Its content will be loaded later whenever the parser instance being used. - It's useful for the cases where need to load thousands of files that belong to one single Spec in one pass of running. - For implementation's convenience, converted the `"scanners"` from `list` `dict` in which the `result_key` is key and `scanner` is value. And removed the `scanner_keys`. - Updated the LsPci accordingly. - RHINENG-13810 Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 1597f13) (cherry picked from commit f2850e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content during initialization. Its content will be loaded later whenever
the parser instance being used.
belong to one single Spec in one pass of running.
"scanners"fromlistdictin which theresult_keyis key andscanneris value. Andremoved the
scanner_keys.All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
blackpre-commitwere also committed in this PR, please majorly check this
code slice which is for this change.