feat: Add is_rhel_ai to parser of os_release #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiazhang <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
wushiqinlou
force-pushed
the
Add_is_rhel_ai_os_release
branch
from
2540787 to
2430b52
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4313 +/- ##
==========================================
+ Coverage 77.17% 77.18% +0.01%
==========================================
Files 765 765
Lines 41753 41773 +20
Branches 8815 8821 +6
==========================================
+ Hits 32221 32243 +22
+ Misses 8464 8463 -1
+ Partials 1068 1067 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
reviewed
Dec 18, 2024
insights/parsers/os_release.py
Outdated
| Returns: | ||
| bool: True when the system is from RHEL AI image. | ||
| """ | ||
| return True if self.get("VARIANT", None) == "RHEL AI" and self.get("VARIANT_ID", None) == "rhel_ai" else False |
There was a problem hiding this comment.
nitpick, how about
return self.get("VARIANT") == "RHEL AI" and self.get("VARIANT_ID") == "rhel_ai"There was a problem hiding this comment.
@xiangce - updated, please confirm
Signed-off-by: jiazhang <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
JoySnow
reviewed
Dec 19, 2024
xiangce
approved these changes
Dec 20, 2024
JoySnow
approved these changes
Dec 20, 2024
xiangce
changed the title
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: jiazhang <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit da76be4)
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
Signed-off-by: jiazhang <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit da76be4) (cherry picked from commit cd9ddc8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add
is_rhel_aifunction to check if the system is from RHEL AI image