test(client): Fix unusual race condition in tests #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes an occasional test failure due to a race condition with the gpg command. The tests in `test_crypto.py` were updated to include the `ignore_errors=True` parameter in `shutil.rmtree(home)`. Signed-off-by: pkoprda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4316 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 765 765
Lines 41770 41770
Branches 8821 8821
=======================================
Hits 32240 32240
Misses 8463 8463
Partials 1067 1067
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
|
@xiangce The PR is ready to be merged 👍 |
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
This change fixes an occasional test failure due to a race condition with the gpg command. The tests in `test_crypto.py` were updated to include the `ignore_errors=True` parameter in `shutil.rmtree(home)`. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit 91adb4e)
xiangce
pushed a commit
that referenced
this pull request
Jan 2, 2025
This change fixes an occasional test failure due to a race condition with the gpg command. The tests in `test_crypto.py` were updated to include the `ignore_errors=True` parameter in `shutil.rmtree(home)`. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit 91adb4e) (cherry picked from commit 2e0e599)
m-horky
added a commit
to m-horky/insights-ansible-playbook-verifier
that referenced
this pull request
Jan 6, 2025
pkoprda
pushed a commit
to RedHatInsights/insights-ansible-playbook-verifier
that referenced
this pull request
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
This change fixes an occasional test failure due to a race condition with the gpg command. The tests in
test_crypto.pywere updated to include theignore_errors=Trueparameter inshutil.rmtree(home).