Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo options to the ls_lanRL spec #4323

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Dec 28, 2024

  • the option was specified as 'lanRl' by mistake
    correct it to lanRL.

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • No Sensitive Data in this change?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

- the option was specified as 'lanRl' by mistake

Signed-off-by: Xiangce Liu <[email protected]>
@xiangce xiangce requested a review from JoySnow December 28, 2024 12:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (721cb83) to head (c26e804).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4323   +/-   ##
=======================================
  Coverage   77.22%   77.22%           
=======================================
  Files         766      766           
  Lines       41822    41822           
  Branches     8839     8839           
=======================================
  Hits        32295    32295           
- Misses       8457     8458    +1     
+ Partials     1070     1069    -1     
Flag Coverage Δ
unittests 77.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wushiqinlou
Copy link
Contributor

@xiangce - LGTM

@xiangce xiangce merged commit dbc93e3 into RedHatInsights:master Dec 30, 2024
15 of 16 checks passed
@xiangce xiangce deleted the fix_ls_lanRL branch December 30, 2024 08:03
xiangce added a commit that referenced this pull request Jan 2, 2025
- the option was specified as 'lanRl' by mistake
  correct it to `lanRL`.

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit dbc93e3)
xiangce added a commit that referenced this pull request Jan 2, 2025
- the option was specified as 'lanRl' by mistake
  correct it to `lanRL`.

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit dbc93e3)
(cherry picked from commit 8c6bdee)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants