feat: add spec parser and combiner for grubby_info #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4329 +/- ##
==========================================
+ Coverage 77.00% 77.03% +0.03%
==========================================
Files 735 736 +1
Lines 41309 41369 +60
Branches 8772 8789 +17
==========================================
+ Hits 31809 31869 +60
Misses 8438 8438
Partials 1062 1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
reviewed
Jan 13, 2025
insights/combiners/grubby.py
Outdated
|
|
||
| Attributes: | ||
| boot_entries (dict): All boot entries indexed by the entry "index" | ||
| default_index (int): the numeric index of the current default boot entry |
There was a problem hiding this comment.
As a combiner, it would be good to combine more useful attribute here, e.g. devs can use the combiner rather than access each single parser to fetch particular info.
|
Attributes from related parsers are included in the new combiner. @xiangce Could you help review the changes? |
JoySnow
force-pushed
the
add-grubby-info
branch
from
3dfcc1b to
c9cc8e6
Compare
Signed-off-by: Xiaoxue Wang <[email protected]>
Signed-off-by: Xiaoxue Wang <[email protected]>
JoySnow
force-pushed
the
add-grubby-info
branch
from
c9cc8e6 to
c0f5f36
Compare
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
approved these changes
Jan 15, 2025
xiangce
pushed a commit
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Xiaoxue Wang <[email protected]> (cherry picked from commit bc73463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
RHINENG-15118
grubby_info_allGrubbyDefaultKernelwith Grubby combiner