feat: Enhanced CephVersion parser to support more versions #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ping Qin <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED
|
Can one of the admins verify this patch? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4334 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 735 735
Lines 41309 41309
Branches 8772 8772
=======================================
Hits 31809 31809
Misses 8438 8438
Partials 1062 1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@xiangce please help review, thanks! |
xiangce
approved these changes
Jan 14, 2025
JoySnow
approved these changes
Jan 15, 2025
xiangce
pushed a commit
that referenced
this pull request
Jan 16, 2025
Signed-off-by: Ping Qin <[email protected]> rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED (cherry picked from commit c530404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ping Qin [email protected]
rh-pre-commit.version: 2.3.1
rh-pre-commit.check-secrets: ENABLED
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here
Enhanced CephVersion parser per https://access.redhat.com/solutions/2045583 to support more versions.