fix(client): Serialize properly playbooks with empty maps #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Card ID: CCT-1101 Empty maps in playbooks were not being correctly handled by the serializer. To maintain compatibility across various environments, they are now serialized as `ordereddict()`. Signed-off-by: pkoprda <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4340 +/- ##
==========================================
- Coverage 77.04% 77.04% -0.01%
==========================================
Files 736 736
Lines 41374 41376 +2
Branches 8790 8791 +1
==========================================
Hits 31877 31877
- Misses 8436 8438 +2
Partials 1061 1061
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangce
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Card ID: CCT-1101 Empty maps in playbooks were not being correctly handled by the serializer. To maintain compatibility across various environments, they are now serialized as `ordereddict()`. Signed-off-by: pkoprda <[email protected]> (cherry picked from commit be6a4ba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Empty maps in playbooks were not being correctly handled by the serializer. To maintain compatibility across various environments, they are now serialized as
ordereddict().This pull request is a backport from insights-ansible-playbook-verifier#29.