-
Notifications
You must be signed in to change notification settings - Fork 82
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The logic of creating a Host model from JSON dict has been scattered between the Host DB model constructor and the deserialization method. Moved everything to the deserializer without changing any logic. Refactored the (de)serialization tests to not work around the bugs and quirks of the Host model constructor: * Invalid default values for account and display_name * Inability to provide all fields as keyword arguments Added tests for the ability to fill an empty string into ansible_host. This is no longer done by a common trusted method.
- Loading branch information
Showing
3 changed files
with
272 additions
and
218 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.