Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RHINENG-4619): Fix deprecation warnings #2176

Merged

Conversation

FabriciaDinizRH
Copy link
Contributor

@FabriciaDinizRH FabriciaDinizRH commented Jan 13, 2025

Overview

This PR is being created to address RHINENG-4619.

  • fixes deprecation warnings after running tests (mostly query deprecation warnings)

a few deprecation warnings are still present, those are related to jsonschema and connexion versions.
To check/validate this PR you can run make test against this PR's branch and against master and notice the warnings at the end.

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Include raw query examples in the PR description, if adding/modifying SQL query
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@FabriciaDinizRH FabriciaDinizRH changed the title RHINENG-4619: Fix deprecation warnings chore(RHINENG-4619): Fix deprecation warnings Jan 13, 2025
@FabriciaDinizRH
Copy link
Contributor Author

/retest

@FabriciaDinizRH
Copy link
Contributor Author

/retest

@FabriciaDinizRH FabriciaDinizRH marked this pull request as ready for review January 20, 2025 23:11
@FabriciaDinizRH FabriciaDinizRH requested a review from a team as a code owner January 20, 2025 23:11
Copy link
Contributor

@thearifismail thearifismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, particularly the use select over db.session.query.

@FabriciaDinizRH FabriciaDinizRH merged commit ec7ae80 into RedHatInsights:master Jan 21, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants