Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-10369): fix merge/replace facts returns #2185

Merged

Conversation

FabriciaDinizRH
Copy link
Contributor

Overview

This PR is being created to address RHINENG-10369.
PATCH /hosts/{id}/facts/{namespace} and PUT /hosts/{id}/facts/{namespace} now returns 404 when given a non-existent hostname or namespace.

PR Checklist

  • Keep PR title short, ideally under 72 characters
  • Descriptive comments provided in complex code blocks
  • Include raw query examples in the PR description, if adding/modifying SQL query
  • Tests: validate optimal/expected output
  • Tests: validate exceptions and failure scenarios
  • Tests: edge cases
  • Recovers or fails gracefully during potential resource outages (e.g. DB, Kafka)
  • Uses type hinting, if convenient
  • Documentation, if this PR changes the way other services interact with host inventory
  • Links to related PRs

Secure Coding Practices Documentation Reference

You can find documentation on this checklist here.

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@FabriciaDinizRH FabriciaDinizRH requested a review from a team as a code owner January 14, 2025 21:20
Copy link
Collaborator

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, LGTM

Copy link
Contributor

@thearifismail thearifismail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kruai
Copy link
Collaborator

kruai commented Jan 20, 2025

/retest

@FabriciaDinizRH
Copy link
Contributor Author

/retest

@FabriciaDinizRH FabriciaDinizRH merged commit 2b415aa into RedHatInsights:master Jan 20, 2025
15 of 16 checks passed
thearifismail pushed a commit to thearifismail/insights-host-inventory that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants