Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting: remove unused variables #342

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Jul 11, 2019

Fixed the F841 Flake8 rule complaning about unused variables.

This is a part of the first step to fix all the formatting. See #189, #335 and #331.

@Glutexo Glutexo self-assigned this Jul 11, 2019
@Glutexo Glutexo mentioned this pull request Jul 11, 2019
@Glutexo Glutexo changed the title Formatting: fix F841 rule Formatting: remove unused variables Jul 11, 2019
@Glutexo Glutexo force-pushed the flake8_variables branch from ce1e730 to 74a7bbb Compare July 11, 2019 08:53
@diegorafrh
Copy link
Contributor

They are both the same #341 - it was intentional?

@Glutexo Glutexo force-pushed the flake8_variables branch 2 times, most recently from fcaf2e8 to ce1e730 Compare July 17, 2019 08:42
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 17, 2019

It wasn’t. I messed up with push targets. Fixed now. Thanks for pointing out!

Fixed the F841 Flake8 rule complaning about unused variables.
@Glutexo Glutexo force-pushed the flake8_variables branch from ce1e730 to b0c3d4c Compare July 17, 2019 14:19
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 17, 2019

Rebased on the current master.

@dehort dehort merged commit c419605 into RedHatInsights:master Jul 17, 2019
@Glutexo Glutexo deleted the flake8_variables branch July 18, 2019 12:36
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 18, 2019

This has been actually merged without an explicit approval. But I suppose that @dehort took a look before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants