DRY the identity pick and validation – now without mocking #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2019
Introduced a new custom Exception to DRY the identity pick and validation. If the header is missing, undecodable or invalid, this new Exception is raised. Aborting the request with a Forbidden status code is not unified in one place.
Glutexo
force-pushed
the
dry_identity_without_mocking
branch
from
0aaf2b7 to
9ce7c41
Compare
|
Refactored and rebased tests for this one too. Hopefully, it won’t be necessary to have this fully merged since we have #76. But it will be worth it to pull some tests from here because they test the whole module and not just single tiny units. |
|
Closing this. I think that the authentication module is tested enough by the tests in test_api.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new custom Exception to DRY the identity pick and validation. If the header is missing, undecodeable or invalid, this new
Exception is raised. Aborting the request with a Forbidden status code is now unified in one place.
This is an alternative version of #76. The executive code is the same, but there is no mocking in the tests. Asking @dehort for a review. Pick any one you like better.