Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure we catch all throwables #221

Merged
merged 1 commit into from
May 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright (C) Red Hat 2023 */
/* Copyright (C) Red Hat 2023-2024 */
package com.redhat.insights;

import static com.redhat.insights.InsightsErrorCode.ERROR_SCHEDULED_SENT;
Expand Down Expand Up @@ -62,14 +62,14 @@ public ScheduledFuture<?> scheduleAtFixedRate(
ix);
shutdown();
throw ix;
} catch (Exception x) {
} catch (Throwable th) {
logger.error(
ERROR_SCHEDULED_SENT.formatMessage(
"Red Hat Insights client scheduler shutdown, non-Insights failure: "
+ x.getMessage()),
x);
+ th.getMessage()),
th);
shutdown();
throw x;
throw th;
}
};

Expand Down