-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: proxies can now be set using HTTPS_PROXY #261
Conversation
08d09a5
to
7ce0b61
Compare
@aslicerh in the end I decidede against showing a messages when |
I think that is a fair assessment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Even if this is a first step, we can do more as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments.
Fixes MWTELE-42
7ce0b61
to
95c9d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For now this simply extracts the host and port from the proxy URL and uses those to connect, just if we were using the RHT_INSIGHTS_JAVA_PROXY_HOST and PORT variables.
This very likely too simple. First I'm not really sure if using RHT_INSIGHTS_JAVA_PROXY_HOST/PORT actually connects using SSL or not and secondly a proxy URL could contain authentication information which we don't use right now.
Fixes MWTELE-42