Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty and loading states for Roles table #1750

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

apinkert
Copy link
Contributor

Adds empty and loading states for Roles table

RHCLOUD-36309

Screenshot 2025-01-24 at 4 05 29 PM

@apinkert apinkert requested a review from a team as a code owner January 24, 2025 21:06
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 40.63%. Comparing base (186626a) to head (8eb7631).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/smart-components/role/RolesTable.tsx 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1750      +/-   ##
==========================================
- Coverage   41.25%   40.63%   -0.63%     
==========================================
  Files         201      203       +2     
  Lines        5565     5653      +88     
  Branches     1457     1480      +23     
==========================================
+ Hits         2296     2297       +1     
- Misses       3053     3140      +87     
  Partials      216      216              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apinkert apinkert changed the title Add empty and leading states for Roles table Add empty and loading states for Roles table Jan 24, 2025
@karelhala karelhala merged commit c0d3ef4 into master Jan 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants