-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHCLOUD-37156] Make reset import tenants admin endpoint use ready=false query instead of looking up all related objects #1454
Merged
petracihalova
merged 9 commits into
RedHatInsights:master
from
petracihalova:query_variation
Jan 28, 2025
Merged
[RHCLOUD-37156] Make reset import tenants admin endpoint use ready=false query instead of looking up all related objects #1454
petracihalova
merged 9 commits into
RedHatInsights:master
from
petracihalova:query_variation
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrozzc
reviewed
Jan 22, 2025
petracihalova
force-pushed
the
query_variation
branch
from
January 22, 2025 22:20
5c1b72a
to
6d466af
Compare
astrozzc
approved these changes
Jan 23, 2025
petracihalova
force-pushed
the
query_variation
branch
from
January 23, 2025 06:03
b6dce82
to
69b8a56
Compare
rebased and conflicts solved |
/retest |
2 similar comments
/retest |
/retest |
we want to remove
…nternal endpoints
petracihalova
force-pushed
the
query_variation
branch
from
January 24, 2025 12:42
69b8a56
to
e9f4c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link(s) to Jira
Description of Intent of Change(s)
we have internal endpoint for reseting imported tenants here
and for tenants identification we are looking up all related objects
this PR introduces the simplification of the query = instead of checking all related objects we can use
ready=false
flagbut because it could be useful to keep the old behavior I added new query parameter
only_ready_false_flag
(with default valuetrue
)only_ready_false_flag=true
=> use query withready=false
flag and get all tenants withready=false
flagonly_ready_false_flag=false
=> use query that is looking up all related objects and get all tenants without related objectsin the perfect world (tenant with
ready=false
does not have related objects) both queries should return same data/resultLocal Testing
you can test it locally with internal endpoint
TODO