Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-15449: Bump tough-cookie to 4.1.4 #588

Merged

Conversation

marleystipich2
Copy link
Collaborator

@marleystipich2 marleystipich2 commented Jan 20, 2025

Kind of a test PR for now. I want to see if we can bump tough-cookie to 4.1.4 which would fix our last vulnerability. tough-cookie is a dependency of [email protected] and [email protected] and technically the version of tough-cookie that they require is ^2.3.3 and ~2.5.0. But overriding the version to ^4.1.3 might be fine...

## Secure Coding Practices Checklist GitHub Link
- https://github.com/RedHatInsights/secure-coding-checklist

## Secure Coding Checklist
- [ ] Input Validation
- [ ] Output Encoding
- [ ] Authentication and Password Management
- [ ] Session Management
- [ ] Access Control
- [ ] Cryptographic Practices
- [ ] Error Handling and Logging
- [ ] Data Protection
- [ ] Communication Security
- [ ] System Configuration
- [ ] Database Security
- [ ] File Management
- [ ] Memory Management
- [ ] General Coding Practices

@marleystipich2 marleystipich2 changed the title Bump tough-cookie to 4.1.4 RHINENG-15449: Bump tough-cookie to 4.1.4 Jan 20, 2025
Copy link
Collaborator

@rexwhite rexwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@marleystipich2 marleystipich2 merged commit fde004d into RedHatInsights:master Jan 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants