-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCXDEV-11589] Add clowdapp for dvo-writer #1906
Conversation
@juandspy we need to use this config field https://github.com/RedHatInsights/insights-results-aggregator/blob/master/config.toml#L53 to use |
Thanks a lot @Bee-lee ! I totally missed that one. Should be fixed in 4afead2. |
0791876
to
0e9cc1e
Compare
deploy/dvo-writer.yaml
Outdated
- name: DVO_WRITER_API_PREFIX | ||
required: true | ||
value: / | ||
- name: IRDW_LOG_STREAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For parameters, I would use more meaningful names instead all this acronyms that we usually use. At the end, those are "local" to the ClowdApp
, so no need to be so pedantic :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 0fc0fb2, ty!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding a Clowdapp for running the dvo-writer.
Type of change
Testing steps
TBD
Checklist
make before_commit
passes