Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCXDEV-11589] Add clowdapp for dvo-writer #1906

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

juandspy
Copy link
Collaborator

Description

Adding a Clowdapp for running the dvo-writer.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Configuration update

Testing steps

TBD

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

deploy/db-writer.yaml Outdated Show resolved Hide resolved
@Bee-lee
Copy link
Collaborator

Bee-lee commented Dec 13, 2023

@juandspy we need to use this config field https://github.com/RedHatInsights/insights-results-aggregator/blob/master/config.toml#L53 to use dvo_recommendations so that it will create a connection for the proper interface

@juandspy
Copy link
Collaborator Author

@juandspy we need to use this config field https://github.com/RedHatInsights/insights-results-aggregator/blob/master/config.toml#L53 to use dvo_recommendations so that it will create a connection for the proper interface

Thanks a lot @Bee-lee ! I totally missed that one. Should be fixed in 4afead2.

@juandspy juandspy marked this pull request as ready for review December 15, 2023 14:38
- name: DVO_WRITER_API_PREFIX
required: true
value: /
- name: IRDW_LOG_STREAM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For parameters, I would use more meaningful names instead all this acronyms that we usually use. At the end, those are "local" to the ClowdApp, so no need to be so pedantic :-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 0fc0fb2, ty!

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juandspy juandspy merged commit fff45b2 into RedHatInsights:master Dec 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants