Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run rbac tests on pr checks #2112

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Don't run rbac tests on pr checks #2112

merged 1 commit into from
Jan 14, 2025

Conversation

juandspy
Copy link
Collaborator

Description

CI is blocked because the rbac plugin cannot connect to the RBAC backend, which is normal as it's deployed. As the RBAC tests are just used on smart-proxy, it's not needed to run them as part of aggregator.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

@juandspy
Copy link
Collaborator Author

/retest

@juandspy juandspy merged commit ecc71c9 into master Jan 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants