Sources returns a 400 if the equal is url encoded (#325)

RedHatInsights · Jan 22, 2024 · 8d951f0 · 8d951f0
1 parent a2e0916
commit 8d951f0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/internal/api/connectors/sources/impl.go b/internal/api/connectors/sources/impl.go
@@ -38,9 +38,12 @@ func NewSourcesClientWithHttpRequestDoer(cfg *viper.Viper, doer HttpRequestDoer)
 				originalUrl := req.URL.String()
 				if strings.Contains(originalUrl, "filter=filter%5B") {
 					// Remove the extra filter parameter name
-					correctedUrl := strings.Replace(req.URL.String(), "filter=", "", -1)
+					urlWithExtraFilterRemoved := strings.Replace(req.URL.String(), "filter=", "", -1)
 
-					newUrl, err := url.Parse(correctedUrl)
+					// Convert the url encoded "=" to unencoded "=" for...otherwise sources returns a 400
+					urlWithEqualUnencoded := strings.Replace(urlWithExtraFilterRemoved, "%3D", "=", -1)
+
+					newUrl, err := url.Parse(urlWithEqualUnencoded)
 					if err != nil {
 						return err
 					}