Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing PR validation error + triggering image build #308

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fixing PR validation error + triggering image build #308

merged 2 commits into from
Oct 25, 2023

Conversation

tahmidefaz
Copy link
Member

@tahmidefaz tahmidefaz commented Oct 24, 2023 •
edited
Loading

What?

  • Updating the Makefile to follow the correct installation guide for the go-jsonschema package
  • This also triggers an image build

Why?

Consider what business or engineering goal does this PR achieves.

How?

Describe how the change is implemented. Any noteable new libaries, APIs, or features.

Testing

Did you add any tests for the change?

Anything Else?

Any other notes about the PR that would be useful for the reviewer.

Secure Coding Practices Checklist Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@tahmidefaz tahmidefaz requested a review from dehort October 24, 2023 20:58
@tahmidefaz tahmidefaz changed the title Trigger image build Fixing PR validation error + triggering image build Oct 25, 2023
dehort
dehort approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@dehort dehort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tahmidefaz tahmidefaz merged commit cdda344 into RedHatInsights:master Oct 25, 2023
@tahmidefaz tahmidefaz deleted the trigger-image-build branch October 25, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehort dehort dehort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahmidefaz @dehort